-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/subseasonal METplus rc1 changes #621
base: develop
Are you sure you want to change the base?
Feature/subseasonal METplus rc1 changes #621
Conversation
Thanks for getting this PR in @ShannonShields-NOAA! The parallel is going to switch to using rc1 after the holidays, so I probably will not merge it into develop until after the switch happens. We can still test this though in the meantime so it is ready to go once that switch happens. |
Sounds good! WCOSS2 is supposed to come back tomorrow, but we shall see about that. Otherwise, hopefully we can test sometime next week if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR and think that the changes in it look good! They are consistent with the changes listed in the PR submission. I approve this PR to be merged once WCOSS2 comes back to developers and the PR is tested. Thanks!
COMOUT is /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr621/evs/v2.0/stats/subseasonal. 1. jevs_subseasonal_cfs_grid2grid_statsLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr621/EVS/dev/drivers/scripts/stats/subseasonal/jevs_subseasonal_cfs_grid2obs_stats.o280744 2. jevs_subseasonal_gefs_grid2grid_statsLog File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr621/EVS/dev/drivers/scripts/stats/subseasonal/jevs_subseasonal_gefs_grid2obs_stats.o280745 |
@malloryprow I have reviewed the output and everything looks correct (no WARNINGs or ERRORs and the G2O stat values match those of the current beta5 EMC parallel). Once the holidays are over and the parallel switches to rc1, this PR should be set to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good and testing successful.
Thanks @ShannonShields-NOAA!
I'm going to hold off on merging until we switch to rc1 in the parallel. I don't want to merge into develop (and para) until then. The plan is to do the switch after the holidays. |
Note to developers: You must use this PR template!
Description of Changes
Developer Questions and Checklist
No
${USER}
where necessary throughout the code.HOMEevs
are removed from the code.dev/drivers/scripts
ordev/modulefiles
have been made in the correspondingecf/scripts
andecf/defs/evs-nco.def
?Testing Instructions